Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to make CI faster #42

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Try to make CI faster #42

wants to merge 8 commits into from
+313 −321

Conversation

Drvi
Copy link
Collaborator

@Drvi Drvi commented Jun 7, 2024 •
edited
Loading

Not sure why the macOS jobs won't start:/

@Drvi Drvi requested a review from d-netto June 7, 2024 18:02
@d-netto
Copy link
Member

d-netto commented Jun 7, 2024

What's the performance impact of this?

@Drvi
Copy link
Collaborator Author

Drvi commented Jun 7, 2024

Locally I get 45 secs on the PR vs 3m45s on master, nightly CI here takes 3 mins, and 12 mins on master

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9420439973

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on td-ci-tweaks at 94.652%
Totals Coverage Status
Change from base Build 9419811816: 94.7%
Covered Lines: 177
Relevant Lines: 187
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9420625731

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on td-ci-tweaks at 94.652%
Totals Coverage Status
Change from base Build 9419811816: 94.7%
Covered Lines: 177
Relevant Lines: 187
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9421163056

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on td-ci-tweaks at 94.652%
Totals Coverage Status
Change from base Build 9419811816: 94.7%
Covered Lines: 177
Relevant Lines: 187
💛 - Coveralls

NHDaly
NHDaly reviewed Jun 14, 2024
View reviewed changes
test/runtests.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (ffd6913) to head (84e92c6).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   90.00%   89.51%   -0.49%     
==========================================
  Files           1        1              
  Lines         190      229      +39     
==========================================
+ Hits          171      205      +34     
- Misses         19       24       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Drvi Drvi requested a review from NHDaly June 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-netto d-netto Awaiting requested review from d-netto

@NHDaly NHDaly Awaiting requested review from NHDaly

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Drvi @d-netto @coveralls @codecov-commenter @NHDaly